Skip to content

Conversation

@scottgigante-immunai
Copy link
Collaborator

Submission type

  • This submission adds a new method

Testing

  • This submission was written in a forked copy of openproblems
  • Nextflow test pipeline is passing on this base branch of this pull
    request (include link to passed test on NF Tower found in GitHub Actions summary: )

Submission guidelines

PR review checklist

This PR will be evaluated on the basis of the following checks:

  • The task addresses a valid open problem in single-cell analysis

@scottgigante-immunai scottgigante-immunai marked this pull request as ready for review March 14, 2023 14:40
@scottgigante-immunai scottgigante-immunai changed the base branch from scvi-scarches-xgb to main March 14, 2023 14:40
@github-actions
Copy link
Contributor

Current build status

@scottgigante-immunai
Copy link
Collaborator Author

Copy link
Collaborator

@LuckyMD LuckyMD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I don't recall all of the xgboost hyperparameters I initially selected, but this looks similar to what i would have gone for ^^. Thanks so much for doing this!

@codecov
Copy link

codecov bot commented Mar 15, 2023

Codecov Report

Patch coverage: 97.29% and project coverage change: -0.12 ⚠️

Comparison is base (9d16650) 95.60% compared to head (d67bada) 95.48%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #853      +/-   ##
==========================================
- Coverage   95.60%   95.48%   -0.12%     
==========================================
  Files         187      188       +1     
  Lines        4980     5055      +75     
  Branches      273      279       +6     
==========================================
+ Hits         4761     4827      +66     
- Misses        141      148       +7     
- Partials       78       80       +2     
Flag Coverage Δ
unittests 95.48% <97.29%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ration/batch_integration_embed/metrics/cc_score.py 100.00% <ø> (ø)
...n/batch_integration_embed/metrics/iso_label_sil.py 100.00% <ø> (ø)
...ntegration/batch_integration_embed/metrics/kBET.py 100.00% <ø> (ø)
...integration/batch_integration_embed/metrics/pcr.py 100.00% <ø> (ø)
...ation/batch_integration_embed/metrics/sil_batch.py 100.00% <ø> (ø)
...tion/batch_integration_embed/metrics/silhouette.py 100.00% <ø> (ø)
...ch_integration_feature/metrics/hvg_conservation.py 100.00% <ø> (ø)
...tegration/batch_integration_graph/methods/bbknn.py 100.00% <ø> (ø)
...egration/batch_integration_graph/methods/combat.py 100.00% <ø> (ø)
...gration/batch_integration_graph/methods/fastmnn.py 100.00% <ø> (ø)
... and 82 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@scottgigante-immunai scottgigante-immunai merged commit cef4e5c into openproblems-bio:main Mar 15, 2023
@mxposed
Copy link
Collaborator

mxposed commented Mar 17, 2023

Thank you, Scott!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants