Skip to content

Conversation

@sebrandon1
Copy link
Member

ioutil has been deprecated since Go 1.16: https://go.dev/doc/go1.16#ioutil

Tracking issue: redhat-best-practices-for-k8s/telco-bot#52

Migration from ioutil to os package:

File and directory operations:

  • Replaced all instances of ioutil.ReadFile, ioutil.WriteFile, and ioutil.ReadDir with os.ReadFile, os.WriteFile, and os.ReadDir respectively throughout the codebase, including files like cfg.go, scmauths.go, sshkey.go, common.go, and their associated test files. [1] [2] [3] [4] [5] [6] [7] [8] [9]

  • Updated all usages of ioutil.TempFile and ioutil.TempDir to os.CreateTemp and os.MkdirTemp respectively, ensuring temporary files and directories are created using the recommended APIs. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14]

Imports and cleanup:

These changes ensure the project is compatible with newer Go versions and avoids deprecated functionality.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 24, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sebrandon1
Once this PR has been reviewed and has the lgtm label, please assign moebasim for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 24, 2025

@sebrandon1: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-image-ecosystem 56f78af link true /test e2e-aws-ovn-image-ecosystem
ci/prow/images 56f78af link true /test images
ci/prow/unit 56f78af link true /test unit
ci/prow/e2e-aws-ovn-builds 56f78af link true /test e2e-aws-ovn-builds
ci/prow/security 56f78af link false /test security
ci/prow/okd-scos-images 56f78af link true /test okd-scos-images
ci/prow/e2e-aws-ovn 56f78af link true /test e2e-aws-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant