Skip to content

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Mar 21, 2025

Bumps github.com/onsi/ginkgo/v2 from 2.22.2 to 2.23.2.

Release notes

Sourced from github.com/onsi/ginkgo/v2's releases.

v2.23.2

2.23.2

🎉🎉🎉

At long last, some long-standing performance gaps between ginkgo and go test have been resolved!

Ginkgo operates by running go test -c to generate test binaries, and then running those binaries. It turns out that the compilation step of go test -c is slower than go test's compilation step because go test strips out debug symbols (ldflags=-w) whereas go test -c does not.

Ginkgo now passes the appropriate ldflags to go test -c when running specs to strip out symbols. This is only done when it is safe to do so and symbols are preferred when profiling is enabled and when ginkgo build is called explicitly.

This, coupled, with the instructions for disabling XProtect on MacOS yields a much better performance experience with Ginkgo.

v2.23.1

2.23.1

🚨 For users on MacOS 🚨

A long-standing Ginkgo performance issue on MacOS seems to be due to mac's antimalware XProtect. You can follow the instructions here to disable it in your terminal. Doing so sped up Ginkgo's own test suite from 1m8s to 47s.

Fixes

Ginkgo's CLI is now a bit clearer if you pass flags in incorrectly:

  • make it clearer that you need to pass a filename to the various profile flags, not an absolute directory [a0e52ff]
  • emit an error and exit if the ginkgo invocation includes flags after positional arguments [b799d8d]

This might cause existing CI builds to fail. If so then it's likely that your CI build was misconfigured and should be corrected. Open an issue if you need help.

v2.23.0

2.23.0

Ginkgo 2.23.0 adds a handful of methods to GinkgoT() to make it compatible with the testing.TB interface in Go 1.24. GinkgoT().Context(), in particular, is a useful shorthand for generating a new context that will clean itself up in a DeferCleanup(). This has subtle behavior differences from the golang implementation but should make sense in a Ginkgo... um... context.

Features

  • bump to go 1.24.0 - support new testing.TB methods and add a test to cover testing.TB regressions [37a511b]

Fixes

  • fix edge case where build -o is pointing at an explicit file, not a directory [7556a86]
  • Fix binary paths when precompiling multiple suites. [4df06c6]

Maintenance

  • Fix: Correct Markdown list rendering in MIGRATING_TO_V2.md [cbcf39a]
  • docs: fix test workflow badge (#1512) [9b261ff]
  • Bump golang.org/x/net in /integration/_fixtures/version_mismatch_fixture (#1516) [00f19c8]
  • Bump golang.org/x/tools from 0.28.0 to 0.30.0 (#1515) [e98a4df]
  • Bump activesupport from 6.0.6.1 to 6.1.7.5 in /docs (#1504) [60cc4e2]
  • Bump github-pages from 231 to 232 in /docs (#1447) [fea6f2d]
  • Bump rexml from 3.2.8 to 3.3.9 in /docs (#1497) [31d7813]
  • Bump webrick from 1.8.1 to 1.9.1 in /docs (#1501) [fc3bbd6]

... (truncated)

Changelog

Sourced from github.com/onsi/ginkgo/v2's changelog.

2.23.2

🎉🎉🎉

At long last, some long-standing performance gaps between ginkgo and go test have been resolved!

Ginkgo operates by running go test -c to generate test binaries, and then running those binaries. It turns out that the compilation step of go test -c is slower than go test's compilation step because go test strips out debug symbols (ldflags=-w) whereas go test -c does not.

Ginkgo now passes the appropriate ldflags to go test -c when running specs to strip out symbols. This is only done when it is safe to do so and symbols are preferred when profiling is enabled and when ginkgo build is called explicitly.

This, coupled, with the instructions for disabling XProtect on MacOS yields a much better performance experience with Ginkgo.

2.23.1

🚨 For users on MacOS 🚨

A long-standing Ginkgo performance issue on MacOS seems to be due to mac's antimalware XProtect. You can follow the instructions here to disable it in your terminal. Doing so sped up Ginkgo's own test suite from 1m8s to 47s.

Fixes

Ginkgo's CLI is now a bit clearer if you pass flags in incorrectly:

  • make it clearer that you need to pass a filename to the various profile flags, not an absolute directory [a0e52ff]
  • emit an error and exit if the ginkgo invocation includes flags after positional arguments [b799d8d]

This might cause existing CI builds to fail. If so then it's likely that your CI build was misconfigured and should be corrected. Open an issue if you need help.

2.23.0

Ginkgo 2.23.0 adds a handful of methods to GinkgoT() to make it compatible with the testing.TB interface in Go 1.24. GinkgoT().Context(), in particular, is a useful shorthand for generating a new context that will clean itself up in a DeferCleanup(). This has subtle behavior differences from the golang implementation but should make sense in a Ginkgo... um... context.

Features

  • bump to go 1.24.0 - support new testing.TB methods and add a test to cover testing.TB regressions [37a511b]

Fixes

  • fix edge case where build -o is pointing at an explicit file, not a directory [7556a86]
  • Fix binary paths when precompiling multiple suites. [4df06c6]

Maintenance

  • Fix: Correct Markdown list rendering in MIGRATING_TO_V2.md [cbcf39a]
  • docs: fix test workflow badge (#1512) [9b261ff]
  • Bump golang.org/x/net in /integration/_fixtures/version_mismatch_fixture (#1516) [00f19c8]
  • Bump golang.org/x/tools from 0.28.0 to 0.30.0 (#1515) [e98a4df]
  • Bump activesupport from 6.0.6.1 to 6.1.7.5 in /docs (#1504) [60cc4e2]
  • Bump github-pages from 231 to 232 in /docs (#1447) [fea6f2d]
  • Bump rexml from 3.2.8 to 3.3.9 in /docs (#1497) [31d7813]
  • Bump webrick from 1.8.1 to 1.9.1 in /docs (#1501) [fc3bbd6]
  • Code linting (#1500) [aee0d56]
  • change interface{} to any (#1502) [809a710]
Commits
  • 979c969 v2.23.2
  • 976a5c0 strip out symbols when running ginkgo
  • 99e2fe2 v2.23.1
  • a0e52ff make it clearer that you need to pass a filename to the various profile flags...
  • b799d8d emit an error and exit if the ginkgo invocation includes flags after position...
  • a565d1f Fix typo in documentation: DescribeHandleSubtree -> DescribeTableSubtree
  • 5157b33 discuss how to disable XProtect on macos
  • 1d705bc v2.23.0
  • 37a511b bump to go 1.24.0 - support new testing.TB methods and add a test to cover te...
  • 7556a86 fix edge case where build -o is pointing at an explicit file, not a directory
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [github.com/onsi/ginkgo/v2](https://github.com/onsi/ginkgo) from 2.22.2 to 2.23.2.
- [Release notes](https://github.com/onsi/ginkgo/releases)
- [Changelog](https://github.com/onsi/ginkgo/blob/master/CHANGELOG.md)
- [Commits](onsi/ginkgo@v2.22.2...v2.23.2)

---
updated-dependencies:
- dependency-name: github.com/onsi/ginkgo/v2
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 21, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dependabot[bot]
Once this PR has been reviewed and has the lgtm label, please assign ajpantuso for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 21, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 21, 2025

Hi @dependabot[bot]. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Mar 24, 2025

Superseded by #490.

@dependabot dependabot bot closed this Mar 24, 2025
@dependabot dependabot bot deleted the dependabot/go_modules/tools/github.com/onsi/ginkgo/v2-2.23.2 branch March 24, 2025 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/deps needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants