Remove unnecessary exception handling and related imports #760
+0
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR simplifies the Java code generator by removing unnecessary exception handling from the generated init() method. The try-catch blocks for NullPointerException and IndexOutOfBoundsException provided no actual error recovery or meaningful handling - they merely printed generic error messages. Removing this boilerplate makes the generated Java code cleaner and more maintainable.
- Removed try-catch wrapper from the generated
init()method's body - Removed unnecessary exception import statements from generated Java files
- Fixed a spelling inconsistency ("NullpointerException" → proper capitalization) as a side effect of removal
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tsh-hashimoto
approved these changes
Dec 5, 2025
yutaro-sakamoto
merged commit 2b8e428
into
opensourcecobol:develop
295 of 296 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request simplifies the generated Java code by removing unnecessary exception handling and related imports from the
init()method in the code generator. The changes focus on making the output Java code cleaner and easier to read.Java code generation cleanup:
try-catchblock forNullPointerExceptionandIndexOutOfBoundsExceptionfrom the generatedinit()method incobj/codegen.c, eliminating redundant error handling code. [1] [2]java.lang.NullPointerExceptionandjava.lang.IndexOutOfBoundsExceptionfrom the generated Java files, as they are no longer needed.