Skip to content

Fix problem_data with problem randomization and show me another. #2855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
drgrice1 wants to merge 2 commits into
base: develop
Choose a base branch
from
+21 −15
Open

Fix problem_data with problem randomization and show me another. #2855

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eacd119
Fix problem_data with problem randomization and show me another.
drgrice1 Dec 5, 2025
0a004d7
Tweak sticky answers with problem randomization a bit more.
drgrice1 Dec 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 17 additions & 14 deletions lib/WeBWorK/ContentGenerator/Problem.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -531,18 +531,16 @@ async sub pre_header_initialize ($c) {
# requiring another answer submission.
my $showReturningFeedback = 0;

# Sticky answers
if (!($c->{submitAnswers} || $previewAnswers || $checkAnswers) && $will{showOldAnswers}) {
# Reinsert sticky answers. Do this only if new answers are NOT being submitted,
# and a new problem version is NOT being opened.
if (!($prEnabled && !$problem->{prCount})
&& !($c->{submitAnswers} || $previewAnswers || $checkAnswers)
&& $will{showOldAnswers})
{
my %oldAnswers = decodeAnswers($problem->last_answer);
# Do this only if new answers are NOT being submitted
if ($prEnabled && !$problem->{prCount}) {
# Clear answers if this is a new problem version
delete $formFields->{$_} for keys %oldAnswers;
} else {
$formFields->{$_} = $oldAnswers{$_} for (keys %oldAnswers);
$showReturningFeedback = 1
if $ce->{pg}{options}{automaticAnswerFeedback} && $problem->num_correct + $problem->num_incorrect > 0;
}
$formFields->{$_} = $oldAnswers{$_} for (keys %oldAnswers);
$showReturningFeedback = 1
if $ce->{pg}{options}{automaticAnswerFeedback} && $problem->num_correct + $problem->num_incorrect > 0;
}

my $showOnlyCorrectAnswers = $c->param('showCorrectAnswers') && $will{showCorrectAnswers};
Expand All @@ -555,7 +553,9 @@ async sub pre_header_initialize ($c) {
$c->{set},
$problem,
$c->{set}->psvn,
$formFields,
$prEnabled
&& !$problem->{prCount}
&& !($c->{submitAnswers} || $previewAnswers || $checkAnswers) ? {} : $formFields,
{
displayMode => $displayMode,
showHints => $will{showHints},
Expand Down Expand Up @@ -588,8 +588,11 @@ async sub pre_header_initialize ($c) {
: 0
),
debuggingOptions => getTranslatorDebuggingOptions($authz, $userID),
$can{checkAnswers}
&& defined $formFields->{problem_data} ? (problemData => $formFields->{problem_data}) : ()
$prEnabled && !$problem->{prCount}
? (problemData => '{}')
: ($can{checkAnswers} && defined $formFields->{problem_data})
? (problemData => $formFields->{problem_data})
: ()
}
);

Expand Down
5 changes: 4 additions & 1 deletion lib/WeBWorK/ContentGenerator/ShowMeAnother.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@ async sub pre_header_initialize ($c) {
effectivePermissionLevel => $db->getPermissionLevel($c->{effectiveUserID})->permission,
useMathQuill => $c->{will}{useMathQuill},
useMathView => $c->{will}{useMathView},
problemData => '{}'
},
);

Expand Down Expand Up @@ -116,6 +117,7 @@ async sub pre_header_initialize ($c) {
effectivePermissionLevel => $db->getPermissionLevel($c->{effectiveUserID})->permission,
useMathQuill => $c->{will}{useMathQuill},
useMathView => $c->{will}{useMathView},
problemData => '{}'
},
);

Expand Down Expand Up @@ -206,7 +208,8 @@ async sub pre_header_initialize ($c) {
showMessages => !$showOnlyCorrectAnswers,
showCorrectAnswers => $showOnlyCorrectAnswers
|| ($c->{will}{checkAnswers} && $c->{will}{showCorrectAnswers}) ? 1 : 0,
debuggingOptions => getTranslatorDebuggingOptions($c->authz, $c->{userID})
debuggingOptions => getTranslatorDebuggingOptions($c->authz, $c->{userID}),
problemData => $c->{formFields}{problem_data} || '{}'
}
);

Expand Down