phase1: fix signing steps when only apk_key is defined #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signing steps are currently skipped if only `apk_key` is configured for a branch, because `IsSignEnabled` only checks for `usign_key` or `gpg_key`. Fix this by explicitly checking for `apk_key`. While at it, refactor the signing checks into dedicated helper functions `IsApkSigningEnabled` and `IsGpgSigningEnabled` for better readability. Signed-off-by: Petr Štetiar <ynezz@true.cz>
ynezz
force-pushed
the
ynezz/fix-signing-config
branch
from
b99ad3b to
b92996c
Compare
openwrt-bot
temporarily deployed
to
production
GitHub Actions
Inactive
openwrt-bot
temporarily deployed
to
production
GitHub Actions
Inactive
openwrt-bot
temporarily deployed
to
production
GitHub Actions
Inactive
openwrt-bot
temporarily deployed
to
production
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signing steps are currently skipped if only
apk_keyis configured for a branch, becauseIsSignEnabledonly checks forusign_keyorgpg_key.Fix this by explicitly checking for
apk_key.While at it, refactor the signing checks into dedicated helper functions
IsApkSigningEnabledandIsGpgSigningEnabledfor better readability.