phase1: fix CONFIG_SIGNED_PACKAGES for apk signing #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently `CONFIG_SIGNED_PACKAGES` is only enabled when `usign_key` is configured. However, we also want to enable it when `apk_key` is configured, as we support signing APK packages as well. So lets fix it by adding `IsSignedPackagesEnabled` helper which checks for both keys and updates the .config generation to use it. Signed-off-by: Petr Štetiar <ynezz@true.cz>
openwrt-bot
temporarily deployed
to
production
GitHub Actions
Inactive
openwrt-bot
temporarily deployed
to
production
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
CONFIG_SIGNED_PACKAGESis only enabled whenusign_keyis configured. However, we also want to enable it whenapk_keyis configured, as we support signing APK packages as well.So lets fix it by adding
IsSignedPackagesEnabledhelper which checks for both keys and updates the .config generation to use it.