phase2: fix signing steps when only apk_key is defined #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signing steps are currently skipped if only APK signing is configured, because phase2 effectively enables signing only when `usign` is present. Fix this by making `IsSignEnabled` explicitly cover APK signing too. While at it, refactor the signing checks into dedicated helper functions `IsUsignEnabled`, `IsApkSigningEnabled`, and `IsGpgSigningEnabled`, and use them consistently to align phase2 with the phase1 implementation. Signed-off-by: Petr Štetiar <ynezz@true.cz>
ynezz
force-pushed
the
ynezz/fix-p2-signing
branch
from
c36a103 to
b0a3bf3
Compare
Member
Author
|
Seems to be working https://buildbot.openwrt.org/openwrt-25.12/packages/#/builders/29/builds/4 
|
openwrt-bot
temporarily deployed
to
production
GitHub Actions
Inactive
openwrt-bot
temporarily deployed
to
production
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signing steps are currently skipped if only APK signing is configured, because phase2 effectively enables signing only when
usignis present.Fix this by making
IsSignEnabledexplicitly cover APK signing too.While at it, refactor the signing checks into dedicated helper functions
IsUsignEnabled,IsApkSigningEnabled, andIsGpgSigningEnabled, and use them consistently to align phase2 with the phase1 implementation.