Skip to content

Conversation

@kraj
Copy link
Contributor

@kraj kraj commented Dec 9, 2025

The systemd unit file installation does not work when the build directory differs from the source directory because cp cannot find the source file. Prefix the unit files with $(srcdir) to reference files from the source tree.

This fixes out-of-tree builds which use separate build directories (B != S).

@chucklever
Copy link
Member

"make distcheck" fails on MUSL. I haven't seen this failure before. Either something in the MUSL set-up has changed or your commit is giving MUSL heartburn. Can you take an initial look into it?

kraj added 2 commits December 10, 2025 17:19
The systemd unit file installation does not work when the build directory
differs from the source directory because cp cannot find the source file.
Prefix the unit files with $(srcdir) to reference files from the source tree.

This fixes out-of-tree builds which use separate build directories (B != S).

Signed-off-by: Khem Raj <raj.khem@gmail.com>
`make distcheck` invokes tar, however, default tar is provided by
busybox on alpine and autoconf's wizardry does not work with the simple
tar implementation that busybox has. Therefore add gnu tar to alpine
CI container.

Ideally, autotools could entertain busybox tar will make it more portable

Signed-off-by: Khem Raj <raj.khem@gmail.com>
@kraj
Copy link
Contributor Author

kraj commented Dec 11, 2025

"make distcheck" fails on MUSL. I haven't seen this failure before. Either something in the MUSL set-up has changed or your commit is giving MUSL heartburn. Can you take an initial look into it?

The failure is not due to the original patch I proposed but in general how autotools are interacting with system tar program, which does not work with busybox tar default on alpine.
ideally a portable way to select tar would be better but for now I have fixed the Github actions script to install gnu tar as a dependency inside Alpine container. That should do it.

@kraj kraj requested a review from alistair23 December 11, 2025 01:36
@chucklever chucklever merged commit ddffadb into oracle:main Dec 11, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants