Fix reference resolution for YAML and JSON strings #54
+50
−29
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an issue introduced with #52 where references in OpenAPI definitions as JSON or YAML strings weren't resolved properly anymore.
Explanation
Fixes #53.
This package previously used OpenAPI PSR-7 Message Validator's factories to create
OpenApispec objects, which also resolved references in case of definition passed as a string (seeJsonFactoryfor instance).When moving away from these factories to introduce support for URLs, manual reference resolution wasn't ported over.
Checklist