Fix cache support and refactor public API #57
Merged
+86
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osteel
force-pushed
the
bugfix/caching
branch
from
8dec6fe to
74ac1f5
Compare
osteel
force-pushed
the
bugfix/caching
branch
from
74ac1f5 to
a3f33ac
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
v0.12broke support for caching. This PR fixes it and clarifies the package's public API.Explanation
This PR restores the use of OpenAPI PSR-7 Message Validator's methods to create SpecObjectInterfaces objects, which was removed with #52 and caused cache support to break.
When passed a URL, the package now reads the content of the URL and passes it to OpenAPI PSR-7 Message Validator's
JsonFactoryorYamlFactoryas a string.The PR also adds the
ValidatorBuilder::fromYamlUrlandValidatorBuilder::fromJsonUrlmethods.Checklist