Rework regex in xx-Remove-emails #87
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hlieberman
force-pushed
the
push-oyqsxqxnzops
branch
from
fe2a03e to
daa1ec3
Compare
brianna-dardin
approved these changes
May 25, 2025
Member
brianna-dardin
left a comment
brianna-dardin
left a comment
There was a problem hiding this comment.
I'm far from a regex expert but playing around with this in regex101 seems like it works just fine. Thanks for updating it!
This changes the regex to be stricter about what it matches in terms of email addresses. That should cut down on the amount of false positives from censored swearing (e.g., "f!@#$%%"). Unscientifically, it's also faster, at least on significant sized archives.
hlieberman
force-pushed
the
push-oyqsxqxnzops
branch
from
daa1ec3 to
5c1c403
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the regex to be stricter about what it matches in terms of email addresses. That should cut down on the amount of false positives from censored swearing (e.g., "f!@#$%%"). Unscientifically, it's also faster, at least on significant sized archives.