Add more filters to slack notifier #27
Conversation
Kuixz
force-pushed
the
clean
branch
7 times, most recently
from
443d59b to
f232b8c
Compare
|
Finally fully cleaned up all commits (separation / squash) :) |
Kuixz
force-pushed
the
clean
branch
3 times, most recently
from
d65d0be to
e2bcfe5
Compare
messy :doglaugh: |
Fix location of used.keys a bit of a rename Update argument description for subscription filter
temp squash Install
Move all command logic into command.go command reword Readability changes to command.go using String methods Uses util array
Update go.mod and go.sum to add goconvey
|
Almost all requested changes have been addressed @cychiuae. Please give it another look at your convenience 👍 I gave "big changes" their own new commit, and "small changes" were rebased / fixup'ed into the existing commits and fpushed. The change regarding the Conclusions enum, I think, is still in progress 🙇 |
|
The location of some functions is quite strange, there are |
|
I'm going to head out early today, please ping me on slack whenever there is updates regarding this PR. Also, i will start pinging you more liberally i.e. every time i believe that i have reached the end of task queue, if you would like to opt out of this please notify me, thx. @cychiuae |
2 participants
Refer issue #21
@cychiuae