Adding Equal class to plog #119
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ourmarina
requested changes
Dec 19, 2022
Co-authored-by: ourmarina <121033780+ourmarina@users.noreply.github.com>
Co-authored-by: ourmarina <121033780+ourmarina@users.noreply.github.com>
ourmarina
reviewed
Dec 28, 2022
| [A: +(x,y,z)>=2, A: -(x,y,z)>=-2] | ||
| [VAR658adc74c6913fb83b42c3968866f4bdb967fcad34692fc71d3de5f9a94b6970: -(x,y,z)>=-2, VARe4568f4a0e4e55b7e3afa57b3527153272b53fde10f6e292b510a5c3bf797d3d: +(x,y,z)>=2] | ||
| """ | ||
|
|
Collaborator
There was a problem hiding this comment.
Do you need to add here that you added the methods to/from json?
Methods
-------
from_json
to_json
And: Do you need the method from_list?
ourmarina
reviewed
Dec 28, 2022
| assert json_model == pg.AtMost.from_json(json_model, [puan.variable]).to_json() | ||
|
|
||
| json_model = {"type": "Equal", "value": 1, "id": "A", "propositions": [{"id": "x", "bounds": {"lower": -10, "upper": 10}}]} | ||
| assert pg.from_json(json_model).to_json() == pg.Equal.from_json(json_model, [puan.variable]).to_json() |
Collaborator
There was a problem hiding this comment.
Is json_model not a json to begin with? Can this not be the same as line 1322 assert json_model == ...?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.