CSS & JS assignments #7
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| const sq = squares.slice() | ||
| sq.fill('') | ||
| setSquares(sq)//배열의 상태는 빈 칸으로 되돌린다. | ||
| status = 'Next player: ' + next;//표시되는 state 역시 되돌린다. |
Owner
There was a problem hiding this comment.
이거 status는 안 바꿔도, 리렌더링할 때 아래 58번 라인 실행돼서 안넣어줘도 돼여
| status = 'Next player: ' + next;//표시되는 state 역시 되돌린다. | ||
| } | ||
| const makeStartButton = () => { | ||
| if(hasWinner() || isFilled) |
Owner
There was a problem hiding this comment.
이거 먼가 코드 가독성 상으로 선언이 아래에 있고 쓰느 게 위에 있어서ㅓ 실수 유발 요소인거 같습니다 .. 실제 실행은 얘가 나중이라 에러는 없겠지만요~ 추후 버그 발생할 가능성도 있고, 함수로 빼준다던가 해서 다른 방법으로 쓰는 게 좋아보입니다요
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2023-03-20 (월) 신입 스터디 과제
노정훈 화이팅