Remove wrong tests violating the precondition and the assertion #688
+2
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The precondition of `RTYPEDDATA_P` is the argument is `RUBY_T_DATA`. https://github.com/ruby/ruby/blob/ruby_3_1/include/ruby/internal/core/rtypeddata.h#L537 ``` * @pre `obj` must be a Ruby object of ::RUBY_T_DATA. ``` Must not call with non-data object, such as `Object` or `String`.
nobu
referenced
this pull request
Dec 31, 2025
* Add stable API support for RTypedData objects - Introduce RTYPEDDATA_P, RTYPEDDATA_EMBEDDED_P, RTYPEDDATA_TYPE, and RTYPEDDATA_GET_DATA macros and stable API methods for working with Ruby's RTypedData objects. - Provide Ruby version-specific implementations (2.6–3.4) for type checking, embedded data detection, type retrieval, and data pointer access. - Add comprehensive tests for RTypedData handling in stable_api_test.rs. - Update CI to test against ruby-head. - Extend blocklists and opaque structs for RData/RTypedData. * Rename Definition to Compiled for stable API Update type and constants to use Compiled struct and Ruby API version constants. * Limit tracking_allocator_test to Ruby <= 3.4 Add cfg to skip failing test on Ruby 3.5 and above. * Update CI to test ruby-head only on Ubuntu Moves ruby-head to its own job with Ubuntu and stable Rust, removing it from the main Ruby matrix to improve CI reliability.
nobu
changed the title
ianks
approved these changes
Jan 5, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The precondition of
RTYPEDDATA_Pis the argument isRUBY_T_DATA.https://github.com/ruby/ruby/blob/ruby_3_1/include/ruby/internal/core/rtypeddata.h#L537
Also violates the assertions in rb-sys itself.