added docs for installing p4sim #706
Open
+1,254
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@fruffy @jafingerhut can you tell where should I add the docs and examples of using p4sim |
We have a doc folder. I would consider placing it there, then hinting on the top-level readme. |
fruffy
reviewed
Dec 10, 2025
doc/Using_p4sim.md
Outdated
|
|
||
| ### Index | ||
|
|
||
| - ⭐ [Local Deployment (ns-3.39)](#local-deployment-ns339) |
There was a problem hiding this comment.
I know LLMs generally use emojis a lot but I would consider dropping them. They're often just clutter.
Author
There was a problem hiding this comment.
I have copy pasted the documentation from the original P4Sim docs will remove the emojis
Signed-off-by: Vineet1101 <vineetgoel692@gmail.com>
Signed-off-by: Vineet1101 <vineetgoel692@gmail.com>
Vineet1101
force-pushed
the
p4sim-exercises
branch
from
eb7ad3a to
7d3d62b
Compare
Author
|
hey @fruffy @jafingerhut can you please review it |
It looks good from my side. @jafingerhut usually merges/manages PRs for this repo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add documents and some example on using P4Sim( a P4 based ns-3 module used to run P4 switches inside ns-3 environment)