Skip to content

Conversation

@halftan
Copy link
Contributor

@halftan halftan commented Jan 4, 2017

May put this into command line argument, but now just use a default one.

May put this into command line argument, but now just use a default one.
@mkusher mkusher merged commit afc664c into padawan-php:master Jan 4, 2017
@mkusher
Copy link
Member

mkusher commented Jan 4, 2017

but it still needs to be fixed here #54

@halftan
Copy link
Contributor Author

halftan commented Jan 4, 2017

yes, I'm working on it. And also some code to make sure that cached index is used while the editing file has semantic errors.

Scenario:
Given file:

<?php
function test_function_one() {
    return new Class();
}

function test_function() {
    if (test_function_one()->{complete here}
}

And indexed file:

<?php
function test_function_one() {
    return new Class();
}

function test_function() {
}

@halftan halftan deleted the enhancement/exclude-test-files-from-indexing branch January 4, 2017 13:25
@halftan halftan restored the enhancement/exclude-test-files-from-indexing branch January 4, 2017 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants