Fix handling of options which set both is_flag=False and flag_value=... #3152
+55
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hensive tests - [pre-commit.ci lite] apply automatic fixes - added required test in test_options, removed seperate test files. Maintained consistency throughout the docs. - Fixed Missing indentaion in CHANGES.rst Co-authored-by: Stephen Rosen <1300022+sirosen@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given that it's >1 month and the original contributor hasn't made changes, I've squashed #3104 and attempted to bring it up to spec so that the one-line fix itself can merge.
To preserve some level of attribution to the original author, I squashed those commits and added myself as a co-author on the resulting commit.
The separate "cleanup" commit aims to fix internal doc, presentation in the changelog, and to tidy up the new test.
Happy to take further action if it's helpful.