Skip to content

Conversation

@cmp0xff
Copy link
Contributor

@cmp0xff cmp0xff commented Dec 8, 2025

Towards #1522, which is too big.

list, Sequence etc. has no default value for the arguments. Replacing all such typing annotations with list[something] etc., so that pyright_strict is happier.

Comment on lines -94 to -103
def format(
self,
name: bool | None = ...,
formatter: Callable[..., Any] | None = ...,
na_rep: str | None = ...,
names: bool = ...,
space: int = ...,
sparsify: bool | None = ...,
adjoin: bool = ...,
) -> list: ...
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Undocumented

@cmp0xff cmp0xff marked this pull request as draft December 8, 2025 13:26
@cmp0xff cmp0xff marked this pull request as ready for review December 8, 2025 13:33
Copy link
Member

@loicdiridollou loicdiridollou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cmp0xff

@loicdiridollou loicdiridollou merged commit 7c90b93 into pandas-dev:main Dec 8, 2025
16 checks passed
@cmp0xff cmp0xff deleted the feature/list branch December 8, 2025 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants