Skip to content

Conversation

@MarcoGorelli
Copy link
Member

@MarcoGorelli MarcoGorelli commented Dec 10, 2025

the following just get inherited from Index:

  • shape
  • __contains__
  • values
  • duplicated
  • get_indexer
  • get_indexer_non_unique
  • reindex
  • equals
  • insert
  • delete

the following are undocumented:

  • __reduce__

the rest i've typed

@MarcoGorelli MarcoGorelli marked this pull request as ready for review December 10, 2025 14:34
@MarcoGorelli MarcoGorelli marked this pull request as draft December 10, 2025 14:39
) -> Self: ...
def view(self, cls=...): ...
def __contains__(self, key) -> bool: ...
def view(self, cls: Any = None) -> MultiIndex: ... # type: ignore[override] # pyrefly: ignore[bad-override] # pyright: ignore[reportIncompatibleMethodOverride]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is an odd one, for multiindex.view, cls is ignored 🤷

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we may be able to refine it, docs suggest: data-type or ndarray sub-class or None

@MarcoGorelli MarcoGorelli marked this pull request as ready for review December 10, 2025 15:13
def insert(self, loc, item): ...
def delete(self, loc): ...
) -> MultiIndex: ...
def equal_levels(self, other: MultiIndex) -> bool: ...
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this actually documented? I can't find it in the docs

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could not find it at all, prob worth deleting unless you have seen use cases in production.

Copy link
Member

@loicdiridollou loicdiridollou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor question but otherwise looking good!

Copy link
Member

@loicdiridollou loicdiridollou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor question but otherwise looking good!

) -> Self: ...
def view(self, cls=...): ...
def __contains__(self, key) -> bool: ...
def view(self, cls: Any = None) -> MultiIndex: ... # type: ignore[override] # pyrefly: ignore[bad-override] # pyright: ignore[reportIncompatibleMethodOverride]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we may be able to refine it, docs suggest: data-type or ndarray sub-class or None

def insert(self, loc, item): ...
def delete(self, loc): ...
) -> MultiIndex: ...
def equal_levels(self, other: MultiIndex) -> bool: ...
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could not find it at all, prob worth deleting unless you have seen use cases in production.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants