CLN: refactor test_frame
#1540
Merged
CLN: refactor test_frame
#1540
+1,230
−1,181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Both in |
loicdiridollou
approved these changes
Dec 10, 2025
Member
loicdiridollou
left a comment
loicdiridollou
left a comment
There was a problem hiding this comment.
Looks good, will trust you that no tests fell through in the moving process, thanks @cmp0xff !
Member
|
Please fix the conflicts and will be merging when good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #1538.
I would like to add tests, but
test_frameis gigantic, and there are so many tests related to getitem and setitem.This PR separates two groups of tests from
test_frame:groupbyandindexing(setitem + getitem).test_groupbyshould contain onlygroupby-related teststest_indexingshould contain only tests related to getitem and setitem.