Skip to content

getMultipleItems function added! (issue #108) #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Mobinapournemat wants to merge 1 commit into
base: master
Choose a base branch
from
Open

getMultipleItems function added! (issue #108) #137

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions cache.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,17 @@ func (c *cache) Get(k string) (interface{}, bool) {
return item.Object, true
}

//GetMultipleItems returns an array of items corresponding to the input array
func (c *cache) GetMultipleItems(values []string) []interface{} {
Copy link

@emstoppel emstoppel Apr 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should it really be called GetMultipleItems, it is a bit stuttery to me, look that the Get function is not called GetItem

length := len(values)
var items = make([]interface{}, length)
Copy link

@emstoppel emstoppel Apr 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i would consider if the length of values is 0 an inmediate return, we could be initializing a 0 length map otherwise

for i := 0; i < length; i++ {
item, _ := c.Get(values[i])
items[i] = item
}
return items
}

// GetWithExpiration returns an item and its expiration time from the cache.
// It returns the item or nil, the expiration time if one is set (if the item
// never expires a zero value for time.Time is returned), and a bool indicating
Expand Down