Skip to content

refactor: use Compose UriHandler as default UrlOpener implementation and make PlatformContext a typealias for Context on Android #372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cbeyls merged 2 commits into from
Mar 30, 2025
Merged

refactor: use Compose UriHandler as default UrlOpener implementation and make PlatformContext a typealias for Context on Android #372

cbeyls merged 2 commits into from
Mar 30, 2025

Conversation

@cbeyls
Copy link
Collaborator

@cbeyls cbeyls commented Mar 30, 2025

  • turn UrlOpener into an interface
  • replace PlatformContext argument with UrlOpener for all use cases that only require opening Urls
  • use UriHandler as Compose implementation of UrlOpener
  • remove OpenLinkUseCase which provides the exact same functionality as UrlOpener
  • make PlatformContext a typealias for Context on Android.

cbeyls added 2 commits March 30, 2025 18:33
@cbeyls
refactor:
fa224c5 
- turn UrlOpener into an interface.
- replace PlatformContext argument with UrlOpener for all use cases that only require opening Urls.
- use UriHandler as Compose implementation of UrlOpener.
- remove OpenLinkUseCase which provides the exact same functionality as UrlOpener.
@cbeyls
refactor: make PlatformContext a typealias for Context on Android
79a3d07
@cbeyls cbeyls self-assigned this Mar 30, 2025
@cbeyls cbeyls merged commit 6b2cf30 into main Mar 30, 2025
1 check passed
@cbeyls cbeyls deleted the refactor/uri_handler branch March 30, 2025 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@cbeyls cbeyls

Labels

enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cbeyls