-
Notifications
You must be signed in to change notification settings - Fork 50
support non PY_VERSION config dir names #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lczub
wants to merge
27
commits into
pericazivkovic:master
Choose a base branch
from
lczub:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this allows to download and build a reduced set of packages. Example: modules.bat Python WxPython Convention: package name XYZ must match subroutine name :UnpackXYZ
new pip install section with IPython example - extract from https://github.com/wheeler-microfluidics/microdrop_portable_python_base/blob/microdrop/2.7/modules.nsh
ipython pip installation needs an unique index description
…py 1.9.2, scipy 0.15.1, PyCharm 4.0.6 and more.
since pyodbc moved from google to github no win installer is published
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Perica,
I tried to build a PortablePython distribution with a different set of modules, cause I do not need all the currently included modules and need some additional ones.
So I copied your 2.7 directory with a different (non-numbering) name like 'robot' and made some changes in that configuration files.
Starting the build fails at the end with an error message like 'VIProductVersion must be X.X.X.X'.
Main reason is, that your build scripts used the 'config dir name' hard coded as PY_VERSION
-> the config dir name must be a number
My suggestion is, that the build script should use the PY_VERSION from the setting.bat file and the config dir name is applied as additional variable PP_TYPE
With this change (and some other), it is possible to build distribution file names like
PortablePython2.7_275.1.0.0orPortablePythonRobot_275.1.0.283.Would it be possible to change your current naming conventions, that non numbering configuration dir names and distribution subnames are supported?
Greetings Luiko