-
Notifications
You must be signed in to change notification settings - Fork 35
gpioioctl: Correct gpioioctl to implement gpio.Group #67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Do I understand we need to roll conn first? |
I've updated go.mod to reference the current version of conn. Separately, I'll need to update devices to use this new version of host to for the hd44780 work go to in. I know this can be done by referencing commits. Is your preference to do a release, or to have the go.mod reference the commit ID we need? |
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (0.0%) is below the target coverage (60.0%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #67 +/- ##
=======================================
- Coverage 27.2% 27.2% -0.0%
=======================================
Files 96 96
Lines 11822 11827 +5
=======================================
Hits 3220 3220
- Misses 8467 8472 +5
Partials 135 135 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
maruel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
| func (ls *LineSet) ByName(name string) *LineSetLine { | ||
|
|
||
| // ByName returns a Line by name from the LineSet. To cast the returned value | ||
| // to a LineSet line, use: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That would be better as an example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to confirm, you're recommending duplicating the example on ByName() to the doc for ByOffset()?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking about creating a toy example in example_test.go but it was really just a nit, don't bother.
|
Feel free to patch .codecov.yml to lower the minimum coverage required. |
|
.. or bypass the check |
This pull requests changes the LineSet from gpioioctl to implement gpio.Group. It pretty much had the requirements but some of the types were subtly different.