Fixes "Attempt to call private method" error

[nathenharvey]

This resolves an error with the StagesController trying to show a stage. It's throwing an error as shown below.

Thanks,
Nathen

NoMethodError in StagesController#show

Attempt to call private method

RAILS_ROOT: /Users/nharvey/projects/webistrano
Application Trace | Framework Trace | Full Trace

/Users/nharvey/projects/webistrano/vendor/bundler/ruby/1.8/gems/activerecord-2.3.11/lib/active_record/attribute_methods.rb:236:in method_missing' /Users/nharvey/projects/webistrano/lib/webistrano/deployer.rb:25:ininitialize'
/Users/nharvey/projects/webistrano/app/models/stage.rb:125:in new' /Users/nharvey/projects/webistrano/app/models/stage.rb:125:inlist_tasks'
/Users/nharvey/projects/webistrano/app/controllers/stages_controller.rb:17:in show' /Users/nharvey/projects/webistrano/app/controllers/application_controller.rb:24:inset_timezone'

Request

Parameters:
{"project_id"=>"1",
"id"=>"1"}

Show session dump
Response

Headers:
{"Content-Type"=>"",
"Cache-Control"=>"no-cache"}

[jmound]

+1 ...would merge again. (I had this error, made the change, and as far as I can tell, all is sunshine again)

[matt-stuart]

I believe that if you reverse the conditionals in the if it should be fine.

25: if(!@deployment.new_record? && @deployment.task)

I noticed, during debugging, that if I asked for the description first and then the task it worked fine.

24: Rails.logger.error "Desc: #{@deployment.description}"
25: Rails.logger.error "Task: #{@deployment.task}"

Putting task first or removing description line caused it to fail. Interesting tidbit.

Edit: I may have spoken too soon. My fix allows for the page to load (likely due to short circuiting) but it fails during an actual deployment load.

[harmon]

+1 for this fix! Please put it in! It's broken.

[thetimbanks]

This fixed the issue for me as well. Thanks!

[cedriclombardot]

👍