-
Notifications
You must be signed in to change notification settings - Fork 2
feat: host recovery #204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
feat: host recovery #204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…w, switch to variadics, debug output
44490ac to
2ab794e
Compare
jason-lynch
reviewed
Dec 2, 2025
Member
jason-lynch
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is close! Just one more change and I think we can call this done for now.
jason-lynch
reviewed
Dec 2, 2025
jason-lynch
approved these changes
Dec 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR enhances the "remove-host" endpoint by adding a "force" option which allows users to recover from situations where a host is lost. Prior to this, calling "remove-host" on a lost host would fail because the internal state would indicate a db running and prevent the removal.
Changes
RemoveHostResponsecontaining a slice of tasks related to the host removalpost_init_handler.goto bypass the instance check during host removalclustertestframework (more below)Testing
Added a new test case and utils to the
clustertestframework:remove-host --forceto remove the missing container from the cluster stateChecklist
Notes for Reviewers
There are a couple related follow-on tasks:
get-database, you can see that there is still an instance leftover in the "unknown" state.WORKAROUNDutil func:control-plane/clustertest/add_remove_host_test.go
Lines 173 to 175 in 845b9a2