test: fix cluster tests for release candidates #214
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The cluster tests use the same image build that we use to publish release images. The tests were also written to use the `latest` tag by default. However, we don't produce a `latest` tag when we publish release candidate images. This caused the tests to fail on the most recent release branch because it was trying to test a nonexistent image. This commit resolves the issue by reusing the existing `CONTROL_PLANE_VERSION` environment variable to compute the default tag in the cluster tests. You can test this change by temporarily creating a pre-release tag and running the tests. > [!CAUTION] > Please be careful not to push this tag by accident because doing so > will trigger a release! ```sh # create a new pre-release tag git tag v0.6.0-rc.1 # run the tests using the pre-release tag make test-cluster # delete the tag git tag -d v0.6.0-rc.1 ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cluster tests use the same image build that we use to publish release images. The tests were also written to use the
latesttag by default. However, we don't produce alatesttag when we publish release candidate images. This caused the tests to fail on the most recent release branch because it was trying to test a nonexistent image.This commit resolves the issue by reusing the existing
CONTROL_PLANE_VERSIONenvironment variable to compute the default tag in the cluster tests.You can test this change by temporarily creating a pre-release tag and running the tests.
Caution
Please be careful not to push this tag by accident because doing so will trigger a release!