Make installcheck step 1 #293
Open
+165
−89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danolivo
force-pushed
the
make-installcheck-step-1
branch
4 times, most recently
from
90c25cc to
f479e09
Compare
Add spock.enable_quiet_mode GUC parameter to reduce message verbosity for cleaner output. When enabled, this parameter: 1. Downgrades DDL replication messages from INFO/WARNING to LOG level - "DDL statement replicated" (INFO → LOG) - "DDL statement replicated, but could be unsafe" (WARNING → LOG) - "This DDL statement will not be replicated" (WARNING → LOG) 2. Suppresses dependent object reporting in DROP CASCADE operations to reduce NOTICE message clutter The parameter defaults to false (disabled) for normal verbose output. Enable it by setting: spock.enable_quiet_mode = true This is useful for regression tests and production environments where less verbose output is desired. All diagnostic messages are preserved in the server log.
danolivo
force-pushed
the
make-installcheck-step-1
branch
from
f479e09 to
d593658
Compare
mason-sharp
requested changes
Dec 30, 2025
| SFUNC = spock.md5_agg_sfunc, | ||
| INITCOND = '' | ||
| ); | ||
|
|
Member
There was a problem hiding this comment.
Was this removed because it is not used? If so, I am reluctant to remove it without checking with others to get the history once they are back from vacation. Please move it to a separate PR so it does not slow this one down.
Other than that, I am ready to approve.
Contributor
Author
There was a problem hiding this comment.
Done.
It seems obvious after excavations that it was an attempt to play with subscriptions/node naming, which is no longer actual.
These two changes to the Spock initial script are intended to make ‘make installcheck’ clearer by avoiding false-positive errors. Adding parallel safety clause to these functions we state we actual behaviour.
1. Bug. In the spock_repset.c module functions replication_set_add_table and replication_set_add_seq should check locking on the table before calling another lock-acquiring routine. It prevents unnecessary calls and reduces the lock level. 2. Improvement. In the spock_queue.c module function queue_message insert a tuple into the spock.queue table. The pattern of this table usage is quite trivial and doesn’t include any concurrent updates. So, we may release the table lock before commit without harm, and let ‘make installcheck’ be more conventional. author: Andrei Lepikhov co-author: Claude
PostgreSQL Core Patch Enhancement (pgXX-015-attoptions.diff): Added IsCatalogRelation() check in GetAttrDelta() function to prevent delta_apply attribute options from being applied to catalog relations. Rationale: - Catalog relations are never replicated via Logical Replication - No use case exists for delta_apply on system catalogs - Applying delta_apply to catalog tables would be meaningless - Early exit improves performance by avoiding unnecessary attribute scans Implementation: - Check added at the beginning of GetAttrDelta() - Returns NULL immediately if relation is a catalog - Includes clear comment explaining the rationale - No functional change for user tables Benefits: - Prevents accidental misconfiguration - Minor performance improvement for catalog operations - Clearer code intent through explicit check - Matches logical replication semantics Note: This patch is applied to PostgreSQL core during build to enable attribute-level options for delta_apply functionality.
In case of IF EXISTS / NOT EXISTS clause Postgres core utility call produces an INFO message and lets utility hooks do their job as usual. In the Spock case, we need to do the same and carefully process the clause so it doesn't produce an ERROR that breaks the convention.
danolivo
force-pushed
the
make-installcheck-step-1
branch
from
d593658 to
b8c623f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This series of commits makes 'make installcheck' visually clear.