Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/spotty-feet-shave.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@phantom/react-native-webview': patch
---

added isMainFrame to onMessage callbacks
Original file line number Diff line number Diff line change
Expand Up @@ -257,7 +257,7 @@ protected void createRNCWebViewBridge(RNCWebView webView) {
this.bridgeListener = new WebViewCompat.WebMessageListener() {
@Override
public void onPostMessage(@NonNull WebView view, @NonNull WebMessageCompat message, @NonNull Uri sourceOrigin, boolean isMainFrame, @NonNull JavaScriptReplyProxy replyProxy) {
RNCWebView.this.onMessage(message.getData(), sourceOrigin.toString());
RNCWebView.this.onMessage(message.getData(), sourceOrigin.toString(), isMainFrame);
}
};
WebViewCompat.addWebMessageListener(
Expand Down Expand Up @@ -339,6 +339,10 @@ public void setInjectedJavaScriptObject(String obj) {
}

public void onMessage(String message, String sourceUrl) {
onMessage(message, sourceUrl, null);
}

public void onMessage(String message, String sourceUrl, @Nullable Boolean isMainFrame) {
ThemedReactContext reactContext = getThemedReactContext();
RNCWebView mWebView = this;

Expand All @@ -352,6 +356,9 @@ public void run() {
}
WritableMap data = mRNCWebViewClient.createWebViewEvent(webView, sourceUrl);
data.putString("data", message);
if (isMainFrame != null) {
data.putBoolean("isMainFrame", isMainFrame);
}

if (mMessagingJSModule != null) {
dispatchDirectMessage(data);
Expand All @@ -363,6 +370,9 @@ public void run() {
} else {
WritableMap eventData = Arguments.createMap();
eventData.putString("data", message);
if (isMainFrame != null) {
eventData.putBoolean("isMainFrame", isMainFrame);
}

if (mMessagingJSModule != null) {
dispatchDirectMessage(eventData);
Expand Down
2 changes: 2 additions & 0 deletions apple/RNCWebViewImpl.m
Original file line number Diff line number Diff line change
Expand Up @@ -773,10 +773,12 @@ - (void)userContentController:(WKUserContentController *)userContentController
_onLoadingFinish(event);
}
} else if ([message.name isEqualToString:MessageHandlerName]) {
BOOL isMainFrame = message.frameInfo.isMainFrame;
if (_onMessage) {
NSMutableDictionary<NSString *, id> *event = [self baseEvent];
[event addEntriesFromDictionary: @{@"data": message.body}];
[event addEntriesFromDictionary: @{@"url": message.frameInfo.request.URL.absoluteString}];
[event addEntriesFromDictionary: @{@"isMainFrame": @(isMainFrame)}];
_onMessage(event);
}
}
Expand Down
1 change: 1 addition & 0 deletions src/RNCWebViewNativeComponent.ts
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ export type WebViewMessageEvent = Readonly<{
canGoForward: boolean;
lockIdentifier: Double;
data: string;
isMainFrame?: boolean;
}>;
export type WebViewOpenWindowEvent = Readonly<{
targetUrl: string;
Expand Down
1 change: 1 addition & 0 deletions src/WebViewTypes.ts
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,7 @@ export type DecelerationRateConstant = 'normal' | 'fast';

export interface WebViewMessage extends WebViewNativeEvent {
data: string;
isMainFrame?: boolean;
}

export interface WebViewError extends WebViewNativeEvent {
Expand Down
Loading