Optimization: reorder the conditions #45
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
CI shows new test failures after this change. For example: |
Collaborator
Author
|
Now I remember: this required a change in pharo-graphics/Bloc#746 It is very simple anyway: the addition of isTextElement in BlElement and BlTextElement. I will commit it on Bloc so this PR has what's needed. |
tinchodias
added a commit
to pharo-graphics/Bloc
that referenced
this pull request
Apr 22, 2025
Required by pharo-graphics/Album#45
Collaborator
Author
|
There are more than 600 tests that fail. But as far as I see, it's unrelated. I see some "Instance of AlbTextEditorNavigator did not understand #whenAdded:" (e.g. in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.