Skip to content

Conversation

@pedroigorjs
Copy link
Contributor

Problem

Timestamps that already included timezone information during Daylight Saving Time (DST) periods were causing errors when attempting to normalize to midnight, as the normalize() method was being applied after timezone conversion.

Solution

Removed the use of normalize() which was causing errors when processing timezone-aware timestamps during DST periods.

Tests

Added test cases covering:

  • Timestamps with explicit timezone (-02:00, -03:00)
  • Dates during DST transition periods
  • Different input formats (ISO 8601, datetime strings)

@pedroigorjs pedroigorjs self-assigned this Dec 3, 2025
@pedroigorjs pedroigorjs added the bug Something isn't working label Dec 3, 2025
@github-actions
Copy link

github-actions bot commented Dec 3, 2025

coverage

Coverage Report
FileStmtsMissCoverMissing
retrack/engine
   base.py50492%35, 97, 104, 107
   executor.py1221092%62, 74–75, 144, 208, 252, 267, 271, 283, 291
   request_manager.py67790%17, 36, 55, 70–71, 154, 157
   rule.py50394%87, 109, 116
retrack/nodes
   check.py41393%23, 26, 89
   constants.py92397%122, 125, 170
   math.py43198%75
retrack/nodes/dynamic
   base.py16194%26
   csv_table.py43295%59, 62
   flow.py44198%18
retrack/utils
   component_registry.py1051883%77–78, 81–82, 85–86, 91–92, 101, 112–123
   exceptions.py28582%17–18, 106–127
   graph.py60788%35, 46, 59, 61, 63, 84, 86
   registry.py34682%23–26, 38, 43, 51
retrack/validators
   base.py4175%14
   node_exists.py15287%36, 38
   node_validator.py33391%31, 56–57
TOTAL14047795% 

Tests Skipped Failures Errors Time
90 0 💤 0 ❌ 0 🔥 5.289s ⏱️

@github-actions
Copy link

github-actions bot commented Dec 3, 2025

coverage

Coverage Report
FileStmtsMissCoverMissing
retrack/engine
   base.py50492%35, 97, 104, 107
   executor.py1221092%62, 74–75, 144, 208, 252, 267, 271, 283, 291
   request_manager.py67790%17, 36, 55, 70–71, 154, 157
   rule.py50394%87, 109, 116
retrack/nodes
   check.py41393%23, 26, 89
   constants.py92397%122, 125, 170
   math.py43198%75
retrack/nodes/dynamic
   base.py16194%26
   csv_table.py43295%59, 62
   flow.py44198%18
retrack/utils
   component_registry.py1051883%77–78, 81–82, 85–86, 91–92, 101, 112–123
   exceptions.py28389%106–127
   graph.py60788%35, 46, 59, 61, 63, 84, 86
   registry.py34682%23–26, 38, 43, 51
retrack/validators
   base.py4175%14
   node_exists.py15287%36, 38
   node_validator.py33391%31, 56–57
TOTAL14047595% 

Tests Skipped Failures Errors Time
90 0 💤 0 ❌ 0 🔥 3.985s ⏱️

@github-actions
Copy link

github-actions bot commented Dec 3, 2025

coverage

Coverage Report
FileStmtsMissCoverMissing
retrack/engine
   base.py50492%35, 97, 104, 107
   executor.py1221092%62, 74–75, 144, 208, 252, 267, 271, 283, 291
   request_manager.py67790%17, 36, 55, 70–71, 154, 157
   rule.py50394%87, 109, 116
retrack/nodes
   check.py41393%23, 26, 89
   constants.py92397%122, 125, 170
   math.py43198%75
retrack/nodes/dynamic
   base.py16194%26
   csv_table.py43295%59, 62
   flow.py44198%18
retrack/utils
   component_registry.py1051883%77–78, 81–82, 85–86, 91–92, 101, 112–123
   exceptions.py28582%17–18, 106–127
   graph.py60788%35, 46, 59, 61, 63, 84, 86
   registry.py34682%23–26, 38, 43, 51
retrack/validators
   base.py4175%14
   node_exists.py15287%36, 38
   node_validator.py33391%31, 56–57
TOTAL14047795% 

Tests Skipped Failures Errors Time
90 0 💤 0 ❌ 0 🔥 5.494s ⏱️

@github-actions
Copy link

github-actions bot commented Dec 3, 2025

coverage

Coverage Report
FileStmtsMissCoverMissing
retrack/engine
   base.py50492%35, 97, 104, 107
   executor.py1221092%62, 74–75, 144, 208, 252, 267, 271, 283, 291
   request_manager.py67790%17, 36, 55, 70–71, 154, 157
   rule.py50394%87, 109, 116
retrack/nodes
   check.py41393%23, 26, 89
   constants.py92397%122, 125, 170
   math.py43198%75
retrack/nodes/dynamic
   base.py16194%26
   csv_table.py43295%59, 62
   flow.py44198%18
retrack/utils
   component_registry.py1051883%77–78, 81–82, 85–86, 91–92, 101, 112–123
   exceptions.py28389%106–127
   graph.py60788%35, 46, 59, 61, 63, 84, 86
   registry.py34682%23–26, 38, 43, 51
retrack/validators
   base.py4175%14
   node_exists.py15287%36, 38
   node_validator.py33391%31, 56–57
TOTAL14047595% 

Tests Skipped Failures Errors Time
90 0 💤 0 ❌ 0 🔥 3.946s ⏱️

@pedroigorjs pedroigorjs merged commit 1edb45d into main Dec 3, 2025
3 checks passed
@pedroigorjs pedroigorjs deleted the b/fix-timestamp-tz-aware-with-dst-time branch December 3, 2025 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants