-
Notifications
You must be signed in to change notification settings - Fork 709
Private link connection #22192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release-8.5
Are you sure you want to change the base?
Private link connection #22192
Conversation
Summary of ChangesHello @shiyuhang0, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a suite of new documentation focused on establishing secure and efficient Private Link connections for TiDB Cloud's dataflow services. These guides provide detailed, step-by-step instructions for connecting TiDB Cloud to various external data sources, including AWS RDS, Alibaba Cloud RDS, AWS Confluent Dedicated clusters, and self-hosted Kafka clusters on AWS, all leveraging cloud-native private link services. The aim is to facilitate private, direct, and secure data transmission, improving both security posture and network performance for users integrating TiDB Cloud with their existing cloud infrastructure. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds several new documentation pages related to setting up Private Link connections for TiDB Cloud Dataflow services. The new documents cover connections to Alibaba Cloud RDS, AWS Confluent, AWS RDS, and self-hosted Kafka on AWS, along with a general overview page. My review focuses on improving clarity, correcting grammatical errors and typos, and ensuring consistency with the repository's style guide. I've provided suggestions to improve sentence structure, use consistent terminology, and fix formatting for better readability.
tidb-cloud/serverless-private-link-connection-to-aws-confluent.md
Outdated
Show resolved
Hide resolved
tidb-cloud/serverless-private-link-connection-to-alicloud-rds.md
Outdated
Show resolved
Hide resolved
tidb-cloud/serverless-private-link-connection-to-alicloud-rds.md
Outdated
Show resolved
Hide resolved
tidb-cloud/serverless-private-link-connection-to-aws-confluent.md
Outdated
Show resolved
Hide resolved
tidb-cloud/serverless-private-link-connection-to-self-hosted-kafka-in-aws.md
Outdated
Show resolved
Hide resolved
tidb-cloud/serverless-private-link-connection-to-alicloud-rds.md
Outdated
Show resolved
Hide resolved
|
Warning Gemini encountered an error creating the review. You can try again by commenting |
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
726c985 to
ca176a2
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
6798c24 to
94b06af
Compare
94b06af to
a5d2ad4
Compare
tidb-cloud/serverless-private-link-connection-to-aws-confluent.md
Outdated
Show resolved
Hide resolved
tidb-cloud/serverless-private-link-connection-to-aws-confluent.md
Outdated
Show resolved
Hide resolved
tidb-cloud/serverless-private-link-connection-to-aws-confluent.md
Outdated
Show resolved
Hide resolved
tidb-cloud/serverless-private-link-connection-to-aws-confluent.md
Outdated
Show resolved
Hide resolved
Co-authored-by: xixirangrang <hfxsd@hotmail.com>
Improved clarity and consistency in instructions for setting up a private link connection to Alibaba Cloud RDS for MySQL. Updated terminology to 'Alibaba Cloud Endpoint Service', clarified steps, and enhanced formatting for better readability. Also updated related references in the general private link connection documentation.
tidb-cloud/serverless-private-link-connection-to-alicloud-rds.md
Outdated
Show resolved
Hide resolved
Moved the reference link for creating an AliCloud Endpoint Service Private Link Connection to the end of the relevant section in 'serverless-private-link-connection-to-alicloud-rds.md'. Added front matter metadata (title and summary) to 'serverless-private-link-connection.md' for improved documentation structure.
7c91d4c to
4c5a5fa
Compare
Improved instructions and terminology in the AliCloud RDS and AWS Confluent private link connection guides. Clarified prerequisites, step-by-step procedures, and updated language for consistency and accuracy.
Improved clarity, consistency, and accuracy in the documentation for connecting TiDB Cloud to Alibaba Cloud RDS, AWS Confluent, and AWS RDS via private link connections. Updates include more precise terminology, step-by-step instructions, and enhanced formatting for prerequisites and procedures. Added links to relevant cloud consoles and guides, and standardized naming conventions for private link connections.
Standardized terminology for Alibaba Cloud (formerly AliCloud) and improved prerequisite instructions in both Alibaba Cloud and AWS Kafka connection guides. Clarified placeholder usage for 'unique_name' and updated references to endpoint services for consistency and accuracy.
7b2267c to
d097da9
Compare
|
@shiyuhang0: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
First-time contributors' checklist
What is changed, added or deleted? (Required)
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?