Skip to content

Conversation

@0xPoe
Copy link
Member

@0xPoe 0xPoe commented Dec 17, 2025

First-time contributors' checklist

What is changed, added or deleted? (Required)

ref pingcap/tidb#64994

Updated the default value of tidb_analyze_column_options to ALL.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 17, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign tangenta for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gemini-code-assist
Copy link

Summary of Changes

Hello @0xPoe, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the documentation to reflect a significant change in the default behavior of the tidb_analyze_column_options system variable. By setting the default to ALL, TiDB will now collect statistics for all columns by default, which is generally beneficial for query optimization, especially in OLAP scenarios. The changes ensure that users are aware of this new default and its implications for statistics collection and performance.

Highlights

  • Default Value Update: The default value for the tidb_analyze_column_options system variable has been updated from PREDICATE to ALL.
  • Documentation Alignment: The documentation for tidb_analyze_column_options has been revised to reflect the new default behavior across different TiDB versions, specifically noting the change for v8.5.5 and later.
  • Performance Tuning Guide Adjustment: A cautionary note in the performance tuning guide regarding increased resource usage when tidb_analyze_column_options is set to ALL has been removed, aligning with the new default recommendation.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 17, 2025
@0xPoe 0xPoe requested a review from Copilot December 17, 2025 09:59
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the documentation for the tidb_analyze_column_options system variable to reflect a change in its default value from PREDICATE to ALL. This change aligns with TiDB PR #64994 and will apply to newly deployed TiDB clusters starting from v8.5.5, as well as v9.0 and master branches. The change means that by default, TiDB will now collect statistics for all columns rather than just predicate columns, which helps avoid suboptimal execution plans in OLAP query scenarios.

Key Changes:

  • Updated the default value of tidb_analyze_column_options from PREDICATE to ALL in system variable documentation
  • Added version-specific notes explaining the default behavior across different TiDB versions (v8.3.0-v8.5.4 vs v8.5.5+)
  • Removed the resource usage warning from the performance tuning guide since ALL is now the default behavior

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
system-variables.md Updated the default value to ALL and added detailed version history notes explaining when the default changed from PREDICATE to ALL for newly deployed clusters
tidb-performance-tuning-config.md Removed the resource usage warning note and simplified the description since ALL is now the default value and the warning is no longer applicable

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly updates the default value of tidb_analyze_column_options to ALL and adjusts the documentation accordingly. My review includes a few suggestions to enhance clarity and restore important contextual information. I've recommended rephrasing the version history for better readability, clarifying a potentially confusing sentence about performance impact, and re-adding a note about the resource usage trade-off in the performance tuning guide.

0xPoe and others added 2 commits December 22, 2025 11:01
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@0xPoe 0xPoe requested review from mjonss and qiancai December 22, 2025 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant