-
Notifications
You must be signed in to change notification settings - Fork 709
tidb: update the default value of tidb_analyze_column_options #22198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Summary of ChangesHello @0xPoe, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the documentation to reflect a significant change in the default behavior of the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates the documentation for the tidb_analyze_column_options system variable to reflect a change in its default value from PREDICATE to ALL. This change aligns with TiDB PR #64994 and will apply to newly deployed TiDB clusters starting from v8.5.5, as well as v9.0 and master branches. The change means that by default, TiDB will now collect statistics for all columns rather than just predicate columns, which helps avoid suboptimal execution plans in OLAP query scenarios.
Key Changes:
- Updated the default value of
tidb_analyze_column_optionsfromPREDICATEtoALLin system variable documentation - Added version-specific notes explaining the default behavior across different TiDB versions (v8.3.0-v8.5.4 vs v8.5.5+)
- Removed the resource usage warning from the performance tuning guide since
ALLis now the default behavior
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| system-variables.md | Updated the default value to ALL and added detailed version history notes explaining when the default changed from PREDICATE to ALL for newly deployed clusters |
| tidb-performance-tuning-config.md | Removed the resource usage warning note and simplified the description since ALL is now the default value and the warning is no longer applicable |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly updates the default value of tidb_analyze_column_options to ALL and adjusts the documentation accordingly. My review includes a few suggestions to enhance clarity and restore important contextual information. I've recommended rephrasing the version history for better readability, clarifying a potentially confusing sentence about performance impact, and re-adding a note about the resource usage trade-off in the performance tuning guide.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
First-time contributors' checklist
What is changed, added or deleted? (Required)
ref pingcap/tidb#64994
Updated the default value of
tidb_analyze_column_optionstoALL.Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?