Skip to content

Conversation

@wildpcww
Copy link
Collaborator

@wildpcww wildpcww commented Dec 24, 2025

First-time contributors' checklist

What is changed, added or deleted? (Required)

Modified autobackup behavior to reflect the new tier design.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

wildpcww and others added 20 commits December 19, 2025 13:33
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Clarified and updated instructions for restoring backups from cloud storage, including revised authentication fields and step order. Added details about regional high availability for premium instances and adjusted step numbering for instance creation.
Moved and consolidated limitations for restoring backups to a dedicated section before the steps. Clarified supported cloud providers, manual backup support, and cross-region fees. Updated prerequisites to focus on required credentials.
Co-authored-by: Grace Cai <qqzczy@126.com>
Expanded documentation links to reference 'Premium' alongside 'Starter' and 'Essential' in high availability sections for clarity and completeness.
Standardized references to high availability documentation in TiDB Cloud by updating link text in architecture-concepts.md and key-concepts.md. Added a note in serverless-high-availability.md to direct users to the dedicated high availability documentation for TiDB Cloud Dedicated.
Co-authored-by: Grace Cai <qqzczy@126.com>
@ti-chi-bot ti-chi-bot bot added contribution This PR is from a community contributor. missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 24, 2025
@gemini-code-assist
Copy link

Summary of Changes

Hello @wildpcww, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the documentation for TiDB Cloud, primarily focusing on the automatic backup behavior and high availability configurations for the Premium tier. The changes reflect a new tier design for backups, providing more detailed information on backup policies and introducing the ability to restore from external cloud storage. Additionally, the documentation now clearly states the default and non-configurable regional high availability setting for Premium instances.

Highlights

  • Enhanced Premium Backup Documentation: The automatic backup section for TiDB Cloud Premium has been significantly revised to detail new policies, including Point-in-Time Recovery (PITR), hourly, and daily snapshots with specific retention periods.
  • New Cloud Storage Restore Option: Documentation for Premium instances now includes a new feature allowing restoration of backups directly from cloud storage (Amazon S3 and Alibaba Cloud OSS).
  • High Availability Configuration Clarification: Updates clarify that TiDB Cloud Premium instances exclusively use regional high availability, which is non-configurable, and this information is now consistently reflected across relevant documentation.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the documentation to reflect new backup and high availability designs, primarily for the Premium tier. The changes are generally clear and align with the new features. My review includes suggestions to fix typos in custom markdown tags, improve phrasing for consistency with the style guide, and reduce repetition for better maintainability. Overall, the updates are good, and my feedback aims to polish the content further.

@hfxsd hfxsd self-assigned this Dec 24, 2025
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 24, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from hfxsd. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hfxsd hfxsd added translation/no-need No need to translate this PR. and removed missing-translation-status This PR does not have translation status info. labels Dec 24, 2025
@hfxsd hfxsd added the area/tidb-cloud This PR relates to the area of TiDB Cloud. label Dec 24, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 24, 2025

@grovecai: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 24, 2025
@hfxsd hfxsd changed the title Newbackupdesign cloud: update backup policies and execution rules Dec 24, 2025
@hfxsd hfxsd requested a review from qqqdan December 24, 2025 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/tidb-cloud This PR relates to the area of TiDB Cloud. contribution This PR is from a community contributor. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. translation/no-need No need to translate this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants