Skip to content

return error if init file failed #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GMHDBJD merged 1 commit into from
Apr 24, 2025
Merged

return error if init file failed #42

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions log.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,10 @@ func initFileLog(cfg *FileLogConfig) (*lumberjack.Logger, error) {
if st.IsDir() {
return nil, errors.New("can't use directory as log file name")
}
} else if !os.IsNotExist(err) {
return nil, err
}

if cfg.MaxSize == 0 {
cfg.MaxSize = defaultLogMaxSize
}
Expand Down
20 changes: 20 additions & 0 deletions zap_log_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,6 +287,26 @@ func TestCompressError(t *testing.T) {
require.Error(t, err)
}

func TestLogFileNoPermission(t *testing.T) {
tempDir, _ := os.MkdirTemp("/tmp", "tests-log")
defer os.RemoveAll(tempDir)
conf := &Config{
Level: "info",
File: FileLogConfig{
Filename: tempDir + "/test.log",
MaxSize: 1,
},
}
_, _, err := InitLogger(conf)
require.NoError(t, err)

err = os.Chmod(tempDir, 0)
require.NoError(t, err)

_, _, err = InitLogger(conf)
require.Contains(t, err.Error(), "permission denied")
}

// testLogSpy is a testing.TB that captures logged messages.
type testLogSpy struct {
testing.TB
Expand Down