Skip to content

Conversation

@winoros
Copy link
Member

@winoros winoros commented Aug 18, 2021

What problem does this PR solve?

Add new option SAMPLERATE to support collect samples by sample rate for statistics

What is changed and how it works?

Add new grammar

Check List

Tests

  • Unit test

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 18, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • tangenta

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot
Copy link
Member

@winoros: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tangenta
Copy link
Contributor

tangenta commented Sep 3, 2021

What is the unit? Percentage?

@ti-chi-bot ti-chi-bot added the status/LGT1 LGT1 label Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants