br: fix region scan checker #64530
br: fix region scan checker #64530
Conversation
Signed-off-by: Jianjun Liao <jianjun.liao@outlook.com>
ti-chi-bot
bot
added
do-not-merge/needs-tests-checked
do-not-merge/needs-triage-completed
release-note-none
|
Hi @Leavrth. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #64530 +/- ##
================================================
+ Coverage 70.7500% 79.6037% +8.8537%
================================================
Files 1895 1988 +93
Lines 518041 558025 +39984
================================================
+ Hits 366514 444209 +77695
+ Misses 127012 110237 -16775
+ Partials 24515 3579 -20936
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
please help push PD side to accept this request tikv/pd#8442 |
Signed-off-by: Jianjun Liao <jianjun.liao@outlook.com>
Got it. I will try |
| } | ||
|
|
||
| func checkRegionConsistency(startKey, endKey []byte, regions []*RegionInfo) error { | ||
| func checkRegionConsistency(startKey, endKey []byte, regions []*RegionInfo, limitted bool) error { |
There was a problem hiding this comment.
Can you add a comment for limited?
| lastRegions = regions | ||
|
|
||
| if err = checkRegionConsistency(startKey, endKey, regions); err != nil { | ||
| if err = checkRegionConsistency(startKey, endKey, regions, false); err != nil { |
There was a problem hiding this comment.
How about moving this to here and not call checkRegionConsistency?
There was a problem hiding this comment.
We need also check the consistency between the adjacent batches, not only the check here. Maybe this duplicate check doesn't consume too much resource?
Signed-off-by: Jianjun Liao <jianjun.liao@outlook.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 3pointer, okJiang The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
approved
lgtm
and removed
needs-1-more-lgtm
|
/ok-to-test |
|
/retest |
3 similar comments
|
/retest |
|
/retest |
|
/retest |
|
@Leavrth: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@Leavrth: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
4 participants
What problem does this PR solve?
Issue Number: close #64514
Problem Summary:
the store id of region leader scanned may be 0.
What changed and how does it work?
add region scan checker to check the leader store id after each region scan API.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.