Skip to content

Conversation

@lcwangchao
Copy link
Contributor

@lcwangchao lcwangchao commented Jul 30, 2025

Signed-off-by: Chao Wang cclcwangchao@hotmail.com

What problem does this PR solve?

Issue Number: close #375

Problem Summary:

To support IndexLookUp push-down, we should introduce some new fields in tipb

What is changed and how it works?

  1. Add a new executor IndexLookUp with type ExecType_TypeIndexLookUp
  2. After IndexLookUp is introduced the DAGRequest.executors should be able to represent a tree instead of a simple array. We explained how executors orders in this PR (compatible with the previous case when each parent has at most one child):
// left child first, then right child, then parent.
// For example, a DAG:
//                A
//               /
//              B
//            /   \
//           C     D
//          /     / \
//         E     F   G
//        /
//       H
// Its order should be: [H, E, C, F, G, D, B, A]
  1. Add a new field parent_idx to Executor to help to parse the DAG.
  2. Add IntermediateOutputChannel and IntermediateOutput for intermediate results.

Related changes

The main tracking issue is: pingcap/tidb#62575

@pingcap-cla-assistant
Copy link

pingcap-cla-assistant bot commented Jul 30, 2025

CLA assistant check
All committers have signed the CLA.

@lcwangchao lcwangchao force-pushed the indexlookup branch 8 times, most recently from 99a97af to 296d236 Compare July 30, 2025 07:12
Signed-off-by: Chao Wang <cclcwangchao@hotmail.com>
@lcwangchao lcwangchao merged commit 85a019a into pingcap:master Aug 29, 2025
3 of 4 checks passed
@lcwangchao lcwangchao deleted the indexlookup branch August 29, 2025 06:24
lcwangchao added a commit to lcwangchao/tipb that referenced this pull request Nov 4, 2025
Signed-off-by: Chao Wang <cclcwangchao@hotmail.com>
lcwangchao added a commit that referenced this pull request Nov 25, 2025
* Add `IndexLookUp` executor and extra output channels (#376)

Signed-off-by: Chao Wang <cclcwangchao@hotmail.com>

* Add field `children` for `IndexLookUp` (#380)

Signed-off-by: Chao Wang <cclcwangchao@hotmail.com>

---------

Signed-off-by: Chao Wang <cclcwangchao@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tipb support IndexLookUp push down

3 participants