string type coercion + improved setup.py + tox #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now you can call `./setup.py test`.
More details on: twbs/bootstrap-sass#506 Now we are using the same libsass version as the node sass.
bwhmather
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, apologies for a slightly large pull request. If you would prefer I can probably do some rebasing to neaten it up.
This incorporates the changes from @mociepka to add python3 support and a couple of tests. My changes add casting from strings to utf-8 bytestrings (important for python3) and clean up the setup.py file, forcing installation of cython. I have also added a tox file for running tests locally.
I believe that the only non backwards-compatible change is in c04aac3: switching from integer constants to strings for output type. This probably doesn't need to be included.