-
Notifications
You must be signed in to change notification settings - Fork 12
Add a new pkgdev commit mangle to remove stable keywords
#202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
One of the most common maintenance tasks in the tree is a simple version bump. With this mangle, `pkgdev commit` can automatically remove the stable keyword from ebuilds copied from a prior version. This should reduce contributor mistakes, and save developers time on both code review and manually editing keywords for their commits.
|
Following some discussion in #gentoo-dev-help
One problem I realized with this, is that it could destabilize a package unintentionally if the whole package is moved by For example |
|
I've added a second commit to cover the scenario where a package is renamed or moved to another category. Because git treats all add & delete in the same commit as mv operations, we need to use a different approach to distinguish the two scenarios, we're now only removing stable keywords when the PV changes. Happy to squash the commits, but I've left them separate until discussion is a bit further along. |
Only redo the keywords if the PV changes over the git mv operation.
|
There are multiple packages which get bumped straight to stable. The current idea is to add a flag to For the moment, we are blocked awaiting that new feature. |
|
@anthonyryan1 can you clarify "blocked awaiting that new feature"- specifically a link to discussions or upstream gentoo bug? |
|
@arthurzam do you have tracking link handy? I'm afraid I've just got a brief IRC exchange, and I've put it out of mind until I heard otherwise. |
One of the most common maintenance tasks in the tree is a simple version bump. With this mangle,
pkgdev commitcan automatically remove the stable keyword from ebuilds copied from a prior version.This should reduce contributor mistakes, and save developers time on both code review and manually editing keywords for their commits.