Borrow API update & Security #13
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Exposed ArgumentParser object as 'parser' to Borrow API by moving it to global scope of module. Rationale is to allow for use with ArgeparseToWebform. - Renamed CLI option 'xlsxfile' to 'xlsxfiles' to make consistent with the Python API. - Altered Python API borrow() function definition. Removed unneeded *. Changed optional params to default to None or False. Strongly coupled CLI and Python API parameter interface by requiring CLI parameters passed to be exactly the same, via dynamically loading list of attribute names from the borrow() function definition.
jkpr
requested changes
Jul 26, 2019
Contributor
jkpr
left a comment
jkpr
left a comment
There was a problem hiding this comment.
I have made some comments on your changes. Please review and I look forward to your feedback ☄️
Contributor
Author
|
@jkpr Thanks for the feedback! I'll prioritize this after the Ethiopia forms, but eager to get back to this. |
Contributor
Author
|
@jkpr Requested changes have been made! |
jkpr
requested changes
Aug 8, 2019
joeflack4
force-pushed
the
feature_borrow-api-update
branch
from
7fd9281 to
25e9e8e
Compare
- Refactored borrow_cli() function to be much cleaner. - Re-added leading * to borrow() function definition to require keyword args. - Removed parser obj from global module variable in favor of cli_parser() constructor. - Updated .gitignore
joeflack4
force-pushed
the
feature_borrow-api-update
branch
from
25e9e8e to
cba1a20
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I will be using this branch to deploy borrow web. I think it is solid enough to merge. But we can review and change things if you would like.
Security
Developer updates
The following was done to improve compatibility, especially with ArgparseToWebform.