-
Notifications
You must be signed in to change notification settings - Fork 12
Use latest version of Directus SDK #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
dannycoulombe
commented
Jul 14, 2021
- use latest version of directus SDK
- redirection behaviours shouldn't be handled from plugin
- auth token automatically updated by Directus
- use cookie names from options
- let main application handle login error handling
- Directus already provides a logout function
- auth token automatically updated by Directus - use cookie names from options - let main application handle login error handling - directus already provides a logout function
|
This looks solid, why hasn't it been merged in? |
I think the author of this repository abandoned its project. I thought about creating a new repo, but at the same time, I don't feel like being responsible of a repo that isn't mine. Anyway, I will rewrite the whole thing soon and create a new repo.. there are still minor issues with this one. |
|
Hey guys! A quick look here? 👀 |
|
Hello @dannycoulombe, thank you for this massive effort and for the time you invested in doing this pull request it's coming from this line. can you help me resolve this error? I tried to check the original SDK but I wasn't able to put my hands on the problem :( I really appreciate any help you can provide. |
|
@RoduanKD it sounds like the version of Axios has been upgraded from If still not working, I would guess that something else needs to be downgraded. Good luck! |