Skip to content

Conversation

@dannycoulombe
Copy link

  • use latest version of directus SDK
  • redirection behaviours shouldn't be handled from plugin
  • auth token automatically updated by Directus
  • use cookie names from options
  • let main application handle login error handling
  • Directus already provides a logout function

dannycoulombe added 6 commits July 13, 2021 09:35
- auth token automatically updated by Directus
- use cookie names from options
- let main application handle login error handling
- directus already provides a logout function
@Sylk
Copy link

Sylk commented Aug 15, 2021

This looks solid, why hasn't it been merged in?

@dannycoulombe
Copy link
Author

This looks solid, why hasn't it been merged in?

I think the author of this repository abandoned its project. I thought about creating a new repo, but at the same time, I don't feel like being responsible of a repo that isn't mine.

Anyway, I will rewrite the whole thing soon and create a new repo.. there are still minor issues with this one.

@hmaesta
Copy link

hmaesta commented Sep 7, 2021

Hey guys! A quick look here? 👀

cc @kaesetoast @pnodev

@RoduanKD
Copy link

Hello @dannycoulombe, thank you for this massive effort and for the time you invested in doing this pull request
I installed this pull request instead of the main version of this package but once I installed it I'm getting this error

_directus_sdk__WEBPACK_IMPORTED_MODULE_3__.AxiosTransport is not a constructor

it's coming from this line.

can you help me resolve this error? I tried to check the original SDK but I wasn't able to put my hands on the problem :(

I really appreciate any help you can provide.

@dannycoulombe
Copy link
Author

@RoduanKD it sounds like the version of Axios has been upgraded from axios-auth-refresh. I don't use Directus anymore and kind of got rid of this codebase as well, so I cannot fix it, but my guess would be to try to downgrade axios-auth-refresh, maybe to a version close to the date of this PR.

If still not working, I would guess that something else needs to be downgraded.

Good luck!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants