Skip to content

Conversation

@GriffinRichards
Copy link
Member

  • Generates include/constants/heal_locations.h using the heal location data, so users don't need to manage them at all.
  • Reverses course a bit from Move heal locations data to their associated map.json #673 by moving heal location data from the respective map.json files back to a single separate file. There was a few reasons for this:
    • Getting the correct value order for heal location constants would otherwise be much messier, probably requiring something like connection_include_order.
    • After Generate local IDs from map.json files #675 the value for respawn_npc can be updated automatically, so it's less important to have that in map.json.
    • It should be faster. Editing heal location data will no longer require processing every map.json file.
    • The inja template should be much simpler to understand at a glance than the C++ code that was in mapjson.

@GriffinRichards GriffinRichards merged commit 7722e7a into pret:porymap-6 Feb 21, 2025
1 check passed
@GriffinRichards GriffinRichards deleted the heal-locations-file branch February 21, 2025 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant