Skip to content

Added SDL3 Checks To Imgui To Fix Clipboard And Typing #867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aardv4rk wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Added SDL3 Checks To Imgui To Fix Clipboard And Typing #867

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
52ab712
Added SDL3 checks to imgui to fix clipboard and typing
aardv4rk Mar 8, 2025
51f5110
updated check to set it once outside of static methods
aardv4rk Mar 8, 2025
e7cf4d0
removed accidental early return
aardv4rk Mar 9, 2025
c6025d0
- renamed CheckForTextInput to UpdateTextInput
aardv4rk Mar 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 41 additions & 4 deletions Nez.ImGui/Core/ImGuiRenderer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@ public class ImGuiRenderer

List<int> _keys = new List<int>();


public ImGuiRenderer(Game game)
{
unsafe
Expand Down Expand Up @@ -143,6 +142,7 @@ public void BeforeLayout(float deltaTime)
{
ImGui.GetIO().DeltaTime = deltaTime;
UpdateInput();
UpdateTextInput();
ImGui.NewFrame();
}

Expand All @@ -167,9 +167,29 @@ public void AfterLayout()
delegate string GetClipboardTextDelegate();
delegate void SetClipboardTextDelegate(IntPtr userData, string txt);

static void SetClipboardText(IntPtr userData, string txt) => SDL2.SDL.SDL_SetClipboardText(txt);
static void SetClipboardText(IntPtr userData, string txt)
{
try
{
SDL3.SDL.SDL_SetClipboardText(txt);
}
catch (DllNotFoundException)
{
SDL2.SDL.SDL_SetClipboardText(txt);
}
}

static string GetClipboardText() => SDL2.SDL.SDL_GetClipboardText();
static string GetClipboardText()
{
try
{
return SDL3.SDL.SDL_GetClipboardText();
}
catch (DllNotFoundException)
{
return SDL2.SDL.SDL_GetClipboardText();
}
}
#endif

/// <summary>
Expand All @@ -182,7 +202,14 @@ void SetupInput()
#if FNA
// forward clipboard methods to SDL
io.SetClipboardTextFn = Marshal.GetFunctionPointerForDelegate<SetClipboardTextDelegate>(SetClipboardText);
io.GetClipboardTextFn = Marshal.GetFunctionPointerForDelegate<GetClipboardTextDelegate>(SDL2.SDL.SDL_GetClipboardText);
try
{
io.GetClipboardTextFn = Marshal.GetFunctionPointerForDelegate<GetClipboardTextDelegate>(SDL3.SDL.SDL_GetClipboardText);
}
catch (DllNotFoundException)
{
io.GetClipboardTextFn = Marshal.GetFunctionPointerForDelegate<GetClipboardTextDelegate>(SDL2.SDL.SDL_GetClipboardText);
}
#endif

_keys.Add(io.KeyMap[(int)ImGuiKey.Tab] = (int)Keys.Tab);
Expand Down Expand Up @@ -279,6 +306,16 @@ void UpdateInput()
_scrollWheelValue = mouse.ScrollWheelValue;
}

void UpdateTextInput()
{
#if FNA
if (ImGui.GetIO().WantTextInput && !TextInputEXT.IsTextInputActive())
TextInputEXT.StartTextInput();
else if (!ImGui.GetIO().WantTextInput && TextInputEXT.IsTextInputActive())
TextInputEXT.StopTextInput();
#endif
}

#endregion


Expand Down