-
Notifications
You must be signed in to change notification settings - Fork 372
Add a way to render tiled layers that are nested within at least one group layer #893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add a way to render tiled layers that are nested within at least one group layer #893
Conversation
|
Looks good, the only issue is that it is a big breaking change for all existing projects. I posted the PR in the discord to start a discussion. One quick and easy alternative would be to just have a new component with the |
…group layer, fixing prime31#892
b6b3c61 to
cef9f7b
Compare
|
I thought about another solution that could still be implemented quite easily and that wouldn't break existing projects. Instead of searching recursively like I did, we could instead ask for a path to the layer, with slashes to indicate going in a group layer. Adding this just in case, the force push was to rebase the master branch on top of this one instead of merging to avoid an unnecessary commit |
|
I just realized that you can put slashes in a tiled layer name, so actually I don't know if it would work that well |
|
thanks for working on this. personally its not an issue for me now(it was once, only briefly when I started), but I can see the utility of having tile layers in groups instead of flattening that out. just giving my two cents. I think the solution where we can resolve the path from the name - using a slash or maybe a double slash (or maybe backslash(es)) might be the best way to go. it does seem intuitive! suppose if no other option, an additional method could be added, like SetLayersToRenderRecursive, using the code you already supplied. and/or an overlloaded constructor. |
…nder These overloads allow using a custom separator character to find the layer name.
|
I implemented the path-like syntax to get layers with slashes or any given separator. |
Following my issue, here is the code change to allow using nested layers for rendering, fixing #892.