Skip to content

Show Upload File button when unauthenticated and prompt login (#3079) #3753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
singhmahipal wants to merge 2 commits into
base: develop
Choose a base branch
from
+8,410 −12,477
Open

Show Upload File button when unauthenticated and prompt login (#3079) #3753

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7e779db
Show Upload File button when unauthenticated and prompt login (#3079)
singhmahipal Dec 10, 2025
f893446
Merge branch 'develop' into feat/login-required-upload
singhmahipal Dec 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 3 additions & 11 deletions .babelrc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,16 +44,10 @@
"@babel/plugin-proposal-function-bind",
["@babel/plugin-proposal-private-methods", { "loose": true }]
],
"presets": [
"@babel/preset-env",
"@babel/preset-react"
]
"presets": ["@babel/preset-env", "@babel/preset-react"]
},
"development": {
"plugins": [
"babel-plugin-styled-components",
"react-refresh/babel"
],
"plugins": ["babel-plugin-styled-components", "react-refresh/babel"],
"presets": [
[
"@babel/preset-react",
Expand All @@ -74,9 +68,7 @@
}
]
],
"plugins": [
"babel-plugin-styled-components"
]
"plugins": ["babel-plugin-styled-components"]
}
},
"plugins": [
Expand Down
76 changes: 37 additions & 39 deletions .eslintrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"extends": ["airbnb", "prettier", "plugin:storybook/recommended"],
"parser": "@babel/eslint-parser",
"env": {
"extends": ["airbnb", "prettier", "plugin:storybook/recommended"],
"parser": "@babel/eslint-parser",
"env": {
"browser": true,
"node": true,
"jest": true
Expand All @@ -17,9 +17,10 @@
"import/no-named-as-default": 0,
"import/no-named-as-default-member": 0,
"import/no-useless-path-segments": 1,
"import/no-cycle":0, //temporarily off
"import/no-cycle": 0, //temporarily off
"import/no-import-module-exports": 0, //temporarily off
"import/extensions": [ // override airbnb setting to allow imports of js, jsx, ts, and tsx files to auto-resolve instead of error
"import/extensions": [
// override airbnb setting to allow imports of js, jsx, ts, and tsx files to auto-resolve instead of error
"error",
"ignorePackages",
{
Expand All @@ -31,9 +32,9 @@
],
"import/prefer-default-export": "off",
"react/jsx-filename-extension": [1, { "extensions": [".jsx", ".tsx"] }],
"comma-dangle": 0, // not sure why airbnb turned this on. gross!
"comma-dangle": 0, // not sure why airbnb turned this on. gross!
"default-param-last": 0,
"no-else-return" :0,
"no-else-return": 0,
"indent": 0,
"no-console": 0,
"no-alert": 0,
Expand All @@ -44,69 +45,66 @@
"no-useless-catch": 2,
"no-plusplus": "off",
"prefer-object-spread": 0,
"max-len": [1, 120, 2, {"ignoreComments": true, "ignoreTemplateLiterals": true}],
"max-len": [
1,
120,
2,
{ "ignoreComments": true, "ignoreTemplateLiterals": true }
],
"max-classes-per-file": 0,
"quote-props": [1, "as-needed"],
"no-unused-vars": [1, {"vars": "local", "args": "none"}],
"no-unused-vars": [1, { "vars": "local", "args": "none" }],
"consistent-return": ["error", { "treatUndefinedAsUnspecified": true }],
"no-param-reassign": [2, { "props": false }],
"react/self-closing-comp": ["error", {
"component": true,
"html": false
}],
"react/self-closing-comp": [
"error",
{
"component": true,
"html": false
}
],
"newline-per-chained-call": 0,
"react/prefer-stateless-function": [2,
{ "ignorePureComponents": true
}],
"react/prefer-stateless-function": [2, { "ignorePureComponents": true }],
"class-methods-use-this": 0,
"react/button-has-type": 0,
"react/destructuring-assignment":0,
"react/destructuring-assignment": 0,
"react/function-component-definition": 0,
"react/jsx-curly-newline":0,
"react/jsx-fragments":0,
"react/jsx-no-useless-fragment":0, // temporarily off
"react/jsx-curly-newline": 0,
"react/jsx-fragments": 0,
"react/jsx-no-useless-fragment": 0, // temporarily off
"react/jsx-one-expression-per-line": 0,
"react/jsx-props-no-spreading": 0,
"react/jsx-wrap-multilines": 0,
"react/jsx-no-bind": [2, {"allowBind": true, "allowArrowFunctions": true, "allowFunctions": true}],
"react/jsx-no-bind": [
2,
{ "allowBind": true, "allowArrowFunctions": true, "allowFunctions": true }
],
"react/no-deprecated": 0, //temporarily off
"react/no-unused-class-component-methods": 1,
"react/sort-comp": 0,
"no-return-assign": [2, "except-parens"],
"jsx-a11y/anchor-is-valid": [
"error",
{
"components": [
"Link"
],
"specialLink": [
"to"
]
"components": ["Link"],
"specialLink": ["to"]
}
],
"jsx-a11y/control-has-associated-label": 0, //temporarily off
"jsx-a11y/label-has-associated-control": 0, //temporarily off
"jsx-a11y/label-has-for": [
2,
{
"components": [
"Label"
],
"components": ["Label"],
"required": {
"every": [
"id"
]
"every": ["id"]
},
"allowChildren": false
}
],
"prettier/prettier": [
"error"
]
"prettier/prettier": ["warn"]
},
"plugins": [
"react", "jsx-a11y", "import", "prettier"
],
"plugins": ["react", "jsx-a11y", "import", "prettier"],
"settings": {
"import/parser": "@babel/eslint-parser",
"import/resolver": {
Expand Down
54 changes: 29 additions & 25 deletions .github/CODE_OF_CONDUCT.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,45 +7,49 @@ We are a community of, and in solidarity with, people from every gender identity
We like these hashtags: #noCodeSnobs (because we value community over efficiency), #newKidLove (because we all started somewhere), #unassumeCore (because we don't assume knowledge), and #BlackLivesMatter (because of course).

In practice:
* We are not code snobs. We do not assume knowledge or imply there are things that somebody should know.
* We insist on actively engaging with requests for feedback regardless of their complexity.
* We welcome newcomers and prioritize the education of others. We strive to approach all tasks with the enthusiasm of a newcomer. Because we believe that newcomers are just as valuable in this effort as experts.
* We consistently make the effort to actively recognize and validate multiple types of contributions.
* We are always willing to offer help or guidance.

- We are not code snobs. We do not assume knowledge or imply there are things that somebody should know.
- We insist on actively engaging with requests for feedback regardless of their complexity.
- We welcome newcomers and prioritize the education of others. We strive to approach all tasks with the enthusiasm of a newcomer. Because we believe that newcomers are just as valuable in this effort as experts.
- We consistently make the effort to actively recognize and validate multiple types of contributions.
- We are always willing to offer help or guidance.

In times of conflict:
* We listen.
* We clearly communicate while acknowledging other's feelings.
* We admit when we're wrong, apologize, and accept responsibility for our actions.
* We are continuously seeking to improve ourselves and our community.
* We keep our community respectful and open.
* We make everyone feel heard.
* We are mindful and kind in our interactions.

- We listen.
- We clearly communicate while acknowledging other's feelings.
- We admit when we're wrong, apologize, and accept responsibility for our actions.
- We are continuously seeking to improve ourselves and our community.
- We keep our community respectful and open.
- We make everyone feel heard.
- We are mindful and kind in our interactions.

In the future:
* The future is now.

- The future is now.

## p5.js Code of Conduct

* **Be mindful of your language.** Any of the following behavior is unacceptable:
* Offensive comments related to gender identity and expression, sexual orientation, race, ethnicity, language, neuro-type, size, ability, class, religion, culture, subculture, political opinion, age, skill level, occupation, or background
* Threats of violence
* Deliberate intimidation
* Sexually explicit or violent material that is not contextualized and preceded by a considerate warning
* Unwelcome sexual attention
* Stalking or following
* Or any other kinds of harassment
- **Be mindful of your language.** Any of the following behavior is unacceptable:

- Offensive comments related to gender identity and expression, sexual orientation, race, ethnicity, language, neuro-type, size, ability, class, religion, culture, subculture, political opinion, age, skill level, occupation, or background
- Threats of violence
- Deliberate intimidation
- Sexually explicit or violent material that is not contextualized and preceded by a considerate warning
- Unwelcome sexual attention
- Stalking or following
- Or any other kinds of harassment

Use your best judgement. If it will possibly make others uncomfortable, do not post it.

* **Be respectful.** Disagreement is not an opportunity to attack someone else's thoughts or opinions. Although views may differ, remember to approach every situation with patience and care.
* **Be considerate.** Think about how your contribution will affect others in the community.
* **Be open minded.** Embrace new people and new ideas. Our community is continually evolving and we welcome positive change.
- **Be respectful.** Disagreement is not an opportunity to attack someone else's thoughts or opinions. Although views may differ, remember to approach every situation with patience and care.
- **Be considerate.** Think about how your contribution will affect others in the community.
- **Be open minded.** Embrace new people and new ideas. Our community is continually evolving and we welcome positive change.

If you believe someone is violating the code of conduct, we ask that you report it by emailing [hello@p5js.org](mailto:hello@p5js.org). Please include your name and a description of the incident, and we will get back to you ASAP.

Sometimes, participants violating the Code of Conduct are unaware that their behavior is harmful, and an open conversation clears things up to move forward. However, if a participant continues with the behavior, the p5.js team may take any action they deem appropriate, up to and including expulsion from all p5.js spaces and identification of the participant as a harasser to other p5.js members or the general public.

---
This statement is licensed under a [Creative Commons license](https://creativecommons.org/licenses/by-sa/4.0/). Please feel free to share and remix with attribution.

This statement is licensed under a [Creative Commons license](https://creativecommons.org/licenses/by-sa/4.0/). Please feel free to share and remix with attribution.
Loading