Make BasicRoomDetails an enum with partial/complete room info
#649
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it possible to express the concept that we have basic info about a room but haven't yet (and need to) fetch the fuller room info (get the `RoomPreview`) in order to display its name, avatar, topic, etc. This is useful when adding new rooms, joining known rooms, navigating to successor rooms, jumping to new/unknown rooms/events, etc.
kevinaboos
force-pushed
the
navigate_to_room_more_flexible
branch
from
33c2078 to
586be61
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it possible to express the concept that we have basic info about a room but haven't yet (and need to) fetch the fuller room info (get the
RoomPreview) in order to display its name, avatar, topic, etc.This is useful when adding new rooms, joining known rooms, navigating to successor rooms, jumping to new/unknown rooms/events, etc.