Correctly configure custom CA volume on Schedule objects generated by the component library
#170
Conversation
We don't necessarily want to drop all contents of `spec.check` or `spec.prune` when we merge an additional `CheckSpec` or `PruneSpec` over an existing `Schedule`. This commit adjusts the two functions to merge their rendered config into key `spec.check` and `spec.prune` instead of fully overwriting those keys.
…helper We need to add the custom CA volume for `check`, `prune` and `backup` in order for schedules that need a custom CA to work correctly. This commit requires the change from the previous commit, so that merging a custom `PruneSpec` over a `Schedule` which configures a custom CA volume doesn't drop that config.
|
🚀 This PR has been released as Triggering workflows 🛠️ Auto tagging enabled with label |
bastjan
left a comment
bastjan
left a comment
There was a problem hiding this comment.
Seems to be alright. One more golden test would help here to verify.
I remember now why I didn't add a golden test yet. Testing the component lib directly from backup-k8up isn't trivially possible without extra Jsonnet, since we currently don't have a generic way to define |
Rendered from template version: main (7e46fac)
|
Added new golden test which exercises the |
simu
force-pushed
the
fix/lib-ca-volume
branch
from
d9d0af1 to
b604720
Compare
Checklist
changelog.
The PR has a meaningful description that sums up the change. It will be
linked in the changelog.
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog.